Condition: split happened X bars ago

kelvinyip

#1

12/20/2017 2:41 PM

I have this code below and I want to break out of the loop when split happened X days ago. When I run it, it doesn't matter what the daysSince number is, fdr.DaysSinceFundamentalItem(bar, out daysSince) always returns true...

What is the proper way to do this ? Which fidelity data should I enable to get split data?

thx

Eugene

#2

12/20/2017 3:48 PM

This function returns the number of calendar days since the last split and, since it was found, it's always true. Are you sure you need this and not the number of bars?

Eugene

#3

12/20/2017 4:21 PM

There are various way to do it. Here's one. Requires Community Components installed (for AddTradingDays). The idea here is to test for the most recent split using GetFundamentalItem (more info in the QuickRef).

kelvinyip

#4

12/20/2017 6:37 PM

Actually, I just don't want to trigger buy if the stock was split yesterday or today .
So, fdr.DaysSinceFundamentalItem(bar, out daysSince) !=1 || fdr.DaysSinceFundamentalItem(bar, out daysSince) !=0 would do it ?

Eugene

#5

12/20/2017 7:01 PM

Are you sure you've seen post #2?

kelvinyip

#6

12/20/2017 11:24 PM

I think post 2 is what I need. thx

Eugene

#7

12/21/2017 6:25 AM

You're welcome.

kelvinyip

#8

12/21/2017 3:14 PM

I am running a 15min strategy from the monitor and I get this. NSP happens to have split recently. what sort of code can I put in to get around this ?
I tried the code on post#2 and it works on daily...but somehow not on intraday... thanks in advance

12/21/2017 6:59:39 AM: Processing 2:1 Stock Split for NSP ...
12/21/2017 6:59:39 AM: Processing 2:1 Stock Split for NSP ...
12/21/2017 6:59:39 AM: Error(3): Object reference not set to an instance of an object.
12/21/2017 6:59:39 AM: Leaving Update Thread from catch

Eugene

#9

12/21/2017 4:06 PM

This works on intraday. Strictly for trading, N/A to backtesting:

kelvinyip

#10

12/26/2017 4:15 PM

What actually causes this type of error ? Let's say I actually want to consider this symbol even though it had a split recently. What/which Fidelity data set am I supposed to update so the split processing would work properly ? I selected Fidelity as datasource. This is in 15 min timeframe market monitoring mode

thx

12/21/2017 6:59:39 AM: Processing 2:1 Stock Split for NSP ...
12/21/2017 6:59:39 AM: Processing 2:1 Stock Split for NSP ...
12/21/2017 6:59:39 AM: Error(3): Object reference not set to an instance of an object.
12/21/2017 6:59:39 AM: Leaving Update Thread from catch

Eugene

#11

12/26/2017 4:40 PM

Let's say it's not the WealthScript code which is discussed here in the thread "Condition: split happened X bars ago".

kelvinyip

#12

12/26/2017 8:25 PM

What did I do wrong here ? 12222017 contains the same symbol set as the 15mins used in this code except 12222017 is daily... When it hits NSP, I get that errror above. thanks

************code sample below******

Size:

Color:

What did I do wrong here ? 12222017 contains the same symbol set as the 15mins used in this code except 12222017 is daily... When it hits NSP, I get that errror above. thanks

************code sample below******

[code]using System;
using System.Collections.Generic;
using System.Text;
using System.Drawing;
using WealthLab;
using WealthLab.Indicators;
using System.IO;

namespace WealthLab.Strategies
{
	public class MyStrategy : WealthScript
	{
		List<string> datalist = new List<string>();
		StrategyParameter strategyParameter1;
		StrategyParameter strategyParameter2;
		public MyStrategy()
		{
			strategyParameter1 = CreateParameter("DOW", 1, 1, 5, 1);
			strategyParameter2 = CreateParameter("back", 1, 1, 10, 1);
		}

public double accVolumeI(int NOW, DataSeries Volume){
			double accVolumeday=0;
			for(int bar = NOW; bar >=0; bar--)

{
				if(bar >lastBarOfXDaysAgo(NOW,1)) {
					accVolumeday=accVolumeday+Volume[bar];
					
				}
				
			}//for
			return accVolumeday;
			
		}
		
		
		
		public int firstBarOfXDaysAgo(int NOW,int daysAgo)
		{

int StartBar = 0;

int cnt = 0;

for(int bar = NOW; bar >=0; bar--)

{

if( Bars.IntradayBarNumber(bar) == 0 ) cnt++;

if( cnt == daysAgo )

{

StartBar = bar;

break;

}

return StartBar;
		}// end of lastbar
		
		
		public int lastBarOfXDaysAgo(int NOW,int daysAgo)
		{

int StartBar = 0;

int cnt = 0;

for(int bar = NOW; bar >=0; bar--)

{

if( Bars.IsLastBarOfDay(bar) == true ) cnt++;

if( cnt == daysAgo )

{

StartBar = bar;

break;

}

return StartBar;
		}// end of lastbar
		
		protected override void Execute()
		{
			
			Bars dailyBars = GetExternalSymbol("12222017", Bars.Symbol, false);    
			 string currentSymbol=Bars.Symbol;
			DataSeries dayVolume = dailyBars.Volume;
			DataSeries dayLow = dailyBars.Low;
			DataSeries dayClose = dailyBars.Close;
			DataSeries dayHigh = dailyBars.High;
			DataSeries daySMA50V=SMA.Series(dayVolume,50);
			dayLow = Synchronize( dayLow );
			dayClose = Synchronize( dayClose );
			dayHigh = Synchronize( dayHigh );
			dayVolume = Synchronize( dayVolume );
			daySMA50V=Synchronize(daySMA50V);
			
			SetScaleCompressed( 15 );
			string path = @"C:\Users\k\kelvin\javaStockAnalysis\wealthlabScan\";
			if (!Directory.Exists(path))
				throw new Exception("You must create the directory " + path);
			int eod=0;
			int firstHalfNeg=0;
			int secondHalfNeg=0;
			int numIntraDayBars=26;
			int mvDays=20;
		
			for(int bar = Bars.Count-(2); bar < Bars.Count; bar++)
			{
			
				
				
				double yesLow=dayLow[bar-1];
				double yesClose=dayClose[bar-1];
				double yesHigh=dayHigh[bar-1];
				eod=0;
				firstHalfNeg=0;
				secondHalfNeg=0;
				int dow=strategyParameter1.ValueInt;
				int barsBack=strategyParameter2.ValueInt;
				Position p=LastPosition;
				if (IsLastPositionActive )
				
					
				{
					if (
						(Bars.IsLastBarOfDay(bar) ==true )
					){
					    
						//PrintDebug("date"+Bars.Date[bar]+"bar"+bar+"entry bar"+Date[p.EntryBar]);
						SellAtClose( bar,p,"sell" );
					}
					
				}
				String dtefmt = "yyyyMMdd";
				string file = path + Date[Bars.Count-1].ToString(dtefmt) + ".csv";
			
				if(
				  
				   !IsLastPositionActive
					
				){
					
					//PrintDebug("dailyV "+daySMA50V[bar]);
					//PrintDebug("dailyV -1 "+daySMA50V[bar]);
					if(

//	High[bar] < High[bar-3]
						//&&
						//Close[bar] < Close[bar-barsBack]
						
					    accVolumeI(bar,Volume)>20000
						&&
						accVolumeI(bar,Volume)>=daySMA50V[bar-1]*1.5
						//half of that volume before the day's end

&& Close[bar]>Close[lastBarOfXDaysAgo(bar,1)]
						&& Close[bar]>2
						
					
					){
						
						//PrintDebug("acc"+	accVolumeI(bar,Volume));
							//PrintDebug("yestV "+	dayVolume[bar]+ " and 50 day vol "+daySMA50V[bar]);
							BuyAtMarket(bar+1,"vol gt 50days Vol");
					
						string csv= currentSymbol+","+Date[bar].ToString(dtefmt);
					
						datalist.Add(csv);
						
						
					}//last half is neg 
				
					
				}// last pos
				
				 File.WriteAllLines(file, datalist);
			}
			
		}
	}		
}

[/code]

Eugene

#13

12/27/2017 6:23 AM

Well your code runs OK for me in the SM on Google 5-minute and EOD data (in "20171222") for NSP:

kelvinyip

#14

12/27/2017 11:57 AM

I did SetScaleCompressed( 15 );

does it have to be 5 mins ?? I am getting this errror everyday .... what should I check ?

Eugene

#15

12/27/2017 12:03 PM

Your

works on lower intraday multiples like 1-Minute, 3-Min, 5-Min only. It has no effect on Daily data nor on 15 min scale - if your question concerned this.

kelvinyip

#16

12/27/2017 12:22 PM

I caught this line in the data update just now

NLR 38145 bars 12/26/2017 3:15 PM 0 bars added
Processing 2:1 Stock Split for NSP ...
Provider update complete for Fidelity Investments

Perhaps, this type of update is not timely... (fidelity dataset) ?

Eugene

#17

12/27/2017 2:23 PM

I'm not sure what do you want from me? I've already provided you different code that works. I cannot reproduce any error.

Unless Cone has a different expert opinion on this it looks intentional and normal to me:

Do you always keep your Fidelity DataSet(s) up to date by running a scheduled or manual update before market hours?

Finally, does the question (or is this an issue) you're raising in this thread negatively affect anything?

kelvinyip

#18

12/27/2017 2:38 PM

I just got the error message again... It does affect my normal operation because the scanning process will quit out. For now, I am manually removing NSP and the monitor would scan properly

Eugene

#19

12/27/2017 3:20 PM

Does it affect this very code only? If so, wrap your logic in a try/catch block. Or would processing the same DataSet stop out at NSP when running plain vanilla code like "Moving Average Crossover"?

Re: your code, I'd like to notice the following. Being run on 15-minute data, SetScaleCompressed(15) is simply N/A. But if it were run on a different bar scale like 5-min, it'd open a can of worms. Because RestoreScale() is missing and due to the restriction in putting trading directives inside a SetScale... block, any trading directives (BuyAtMarket, SellAtClose...) that go below SetScaleCompressed() would be in la-la land.

kelvinyip

#20

12/27/2017 3:28 PM

oh, I only run it on 15 mins, so I can get rid of the SetScaleCompressed... I didn't know I can put regular java stuff like try catch. Cool, let me try that. thx

Eugene

#21

12/27/2017 3:34 PM

Before you try it out, what about "Moving Average Crossover" first?

kelvinyip

#22

12/27/2017 4:05 PM

I used the out of the box "Moving Average Crossover" , I suppose that's the one.. and ran it on the 15 mins time frame with NSP added back into my daily and 15mins dataSets...

same error

12/27/2017 8:03:34 AM: Processing 2:1 Stock Split for NSP ...
12/27/2017 8:03:34 AM: Processing 2:1 Stock Split for NSP ...
12/27/2017 8:03:34 AM: Error(3): Object reference not set to an instance of an object.
12/27/2017 8:03:34 AM: Leaving Update Thread from catch

Eugene

#23

12/27/2017 5:06 PM

Okay, as I told in post #11 we've deviated way too far from subject which is "Condition: split happened X bars ago". That task is done, and for the rest I've run out of my suggestions. Everything since post #8 is off topic so this is going to be my final reply here.

If this error negatively affects the processing of any Strategy running in the SM, please start a new topic for what seems to be a general SM issue and copy all relevant information including the logs, settings and procedure to reproduce. Thanks.