Close all positions on the last bar

Author: algotradingwl

Creation Date: 3/22/2016 1:42 PM

Wealth Lab » WealthScript (.NET) » Close all positions on the last bar

algotradingwl

3/22/2016 1:42 PM

Plz tell me what is my mistake. All positions should be closed on the last bar (ExitAtMarket( bar + 1, p, "Exit at last bar") , but this is not happening:

CODE:
Please log in to see this code.

Size:

Color:

Plz tell me what is my mistake. All positions should be closed on the last bar (ExitAtMarket( bar + 1, p, "Exit at last bar") , but this is not happening:
 
[code]
using System;
using System.Collections.Generic;
using System.Text;
using System.Drawing;
using WealthLab;
using WealthLab.Indicators;

namespace WealthLab.Strategies
{
	public class envelop : WealthScript
	{
		private StrategyParameter paramPeriod;
				
		public envelop()
		{
			paramPeriod = CreateParameter("Ch Period", 150, 10, 200, 10);
		}
		
		protected override void Execute()
		{
			double RiskPerTrade=0.04;
			//Get values of parameters
			int period = paramPeriod.ValueInt;
						
			//Obtain pch indicators
			DataSeries ChUpper = Highest.Series(High, period);
			DataSeries ChLower = Lowest.Series(Low, period);
			
			PlotSeries(PricePane, ChUpper >> 1, Color.Green, LineStyle.Solid, 1);
			PlotSeries(PricePane, ChLower >> 1, Color.Red, LineStyle.Solid, 1);			
			
			//trading system rules1
			for(int bar = period; bar < Bars.Count; bar++)
			{
				if (IsLastPositionActive)
				{
					Position p = LastPosition;
					
					if (bar == Bars.Count-1)
					{
						ExitAtMarket( bar + 1, p, "Exit at last bar");
					}
					
					if( p.PositionType == PositionType.Long )
					{
						if ( CrossUnder (bar, Close, ChLower>>1))
						{
							SellAtMarket(bar+1,p,"Sell1");
						}
					}
					
					if( p.PositionType == PositionType.Short )
					{
						if ( CrossOver (bar, Close, ChUpper>>1))
						{
							CoverAtMarket (bar+1, p, "Cover1");
						}
					}
					
				}
				if (!IsLastPositionActive)
				{
					if ( CrossOver (bar, Close, ChUpper>>1))
					{	
						BuyAtMarket(bar+1,"Buy1");
						LastPosition.Tag=((RiskPerTrade/(Math.Abs(LastPosition.EntryPrice-ChLower[bar])/LastPosition.EntryPrice))*100);
					}
				
					if ( CrossUnder (bar, Close, ChLower>>1))
					{	
						ShortAtMarket(bar+1,"Short1");
						LastPosition.Tag=((RiskPerTrade/(Math.Abs(LastPosition.EntryPrice-ChUpper[bar])/LastPosition.EntryPrice))*100);
					}
				}
			}
			
		}
	}
}
 [/code]

Eugene

3/22/2016 2:16 PM

Welcome to the forums Dima.

The thing is, the Position will never be closed because Bars.Count is dynamic (increasing with each new bar added) and your trade is an Alert for bar+1 (that new bar). So if you don't care about getting that alert (for you know that this Position is being closed anyway):