CustomSettings is empty in custom Optimizer

Panache

#1

12/17/2016 6:47 PM

Something is wrong with the ICustom Settings in my custom Optimizer that I derived from the open source Average Volume Limitation PosSizer in the WIKI. The relevant code in my Optimizer is:

CODE:
Please log in to see this code.

When I click on Settings in my Optimizer, the Optimizer Settings dialog box is empty, instead of being populated with my Options User Control. Also, nothing is being written to WealthLabConfig.txt. Obviously, I'm doing something wrong, but I can't find the problem.

Size:

Color:

Something is wrong with the ICustom Settings in my custom Optimizer that I derived from the open source Average Volume Limitation PosSizer in the WIKI.  The relevant code in my Optimizer is:

[code]    public class Options : UserControl
    {
        [Generated code]

public int NumberOfSteps
        {
            get
            {
                return (int)this.numberOfSteps.Value;
            }
            set
            {
                this.numberOfSteps.Text = value.ToString();
            }
        }
        public int MetricIndex
        {
            get
            {
                return (int)this.metric.SelectedIndex;
            }
            set
            {
                this.metric.SelectedIndex = value;
            }
        }
        public bool PlaySound
        {
            get
            {
                return (bool)this.playSound.Checked;
            }
            set
            {
                this.playSound.Checked = value;
            }
        }
    }
    public class Abacus_Optimizer : Optimizer, ICustomSettings
    {
        private int _numberOfSteps = 5;
        private int _metricIndex = 0;
        private bool _playSound = true;
        private Options _settings = new Options();

[required voids]

#region ICustomSettings
        /*
        // Not used for Optimizers
        public override string GetConfigString()
        {
            return base.GetConfigString()
                + this._numberOfSteps + "|"
                + this._metricIndex + "|"
                + this._playSound + "|";
        }
        public override void ApplyConfigString(string config)
        {
            string[] tokens = config.Split('|');
            this._numberOfSteps = Int32.Parse(tokens[0]);
            this._metricIndex = Int32.Parse(tokens[1]);
            this._playSound = Boolean.Parse(tokens[2]);
        }
        */

public UserControl GetSettingsUI()
        {
            //Host.MetricNames;
            if (this._settings == null)
            {
                this._settings.NumberOfSteps = this._numberOfSteps;
                this._settings.MetricIndex = this._metricIndex;
                this._settings.PlaySound = this._playSound;
            }
            return this._settings;
        }

public void ChangeSettings(UserControl ui)
        {
            this._numberOfSteps = this._settings.NumberOfSteps;
            this._metricIndex = this._settings.MetricIndex;
            this._playSound = this._settings.PlaySound;
        }

public void ReadSettings(ISettingsHost host)
        {
            string s = "Optimizer.Abacus.";
            this._numberOfSteps = host.Get(s + "NumberOfSteps", (int)5);
            this._metricIndex = host.Get(s + "MetricIndex", (int)0);
            this._playSound = host.Get(s + "PlaySound", (bool)true);
        }

public void WriteSettings(ISettingsHost host)
        {
            string s = "Optimizer.Abacus.";
            host.Set(s + "NumberOfSteps", this._settings.NumberOfSteps);
            host.Set(s + "MetricIndex", this._settings.MetricIndex);
            host.Set(s + "PlaySound", this._settings.PlaySound);
        }
        #endregion
    }[/code]

When I click on Settings in my Optimizer, the Optimizer Settings dialog box is empty, instead of being populated with my Options User Control.  Also, nothing is being written to WealthLabConfig.txt.  Obviously, I'm doing something wrong, but I can't find the problem.

LenMoz

#2

12/17/2016 8:20 PM

I don't think you're executing your initialization code because you've instantiated _settings at its declaration so it isn't null in GetSettingsUI. Declare it simply as "private Options _settings;", then add the indicated line in GetSettingsUI.

CODE:
Please log in to see this code.

Panache

#3

12/17/2016 9:13 PM

Thanks, but that is now giving me an unhandled null reference exception at

CODE:
Please log in to see this code.

this.numberOfSteps is null.

I need to get away from this for awhile, but thank you for holding my hand for the last two days.

Panache

#4

12/18/2016 3:54 AM

I decided to go back to basics and use a simple optimizer and add the ICustomSettings implementation from Community.Commissions to make sure I hadn't screwed something else up. That is now giving me a new error message 'Abacus_User_Interface.UserControls.numberOfSteps' is inaccessible due to its protection level.

Here's the full code:

Edited by Eugene: fixed overquoting of MS123 LLC intellectual property

CODE:
Please log in to see this code.

Size:

Color:

I decided to go back to basics and use a simple optimizer and add the ICustomSettings implementation from Community.Commissions to make sure I hadn't screwed something else up.  That is now giving me a new error message 'Abacus_User_Interface.UserControls.numberOfSteps' is inaccessible due to its protection level.

Here's the full code:

[color=#f700ff]Edited by Eugene: fixed overquoting of MS123 LLC intellectual property[/color]

[code]using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;
using Fidelity.Components;
using WealthLab;
using WealthLab.Extensions.Attribute;

namespace MyWealthLabLibrary.Optimizers
{

public class Test : Optimizer, ICustomSettings
    {
        private Abacus_User_Interface.UserControls _settingsUI;
        private int _numberOfSteps = 5;
...
        public override void Initialize()
        {
            //Host.CreateTab("Optimization Performance", Custom_Tab.CustomTab); // NOW GENERATING THE ERROR Custom_Tab.CustomTab is a 'type', which is not valid in the given context 
        }

public override void FirstRun()
        {
            foreach (StrategyParameter param in WealthScript.Parameters)
            {
                param.Value = param.Start;
            }
        }

public override bool NextRun(SystemPerformance sp, OptimizationResult or)
        {
            return incrementParam(WealthScript.Parameters.Count - 1);
        }

protected bool incrementParam(int ind)
        {
            if (ind >= 0)
            {
                StrategyParameter param = WealthScript.Parameters[ind];
                if (param.Value < param.Stop)
                {
                    param.Value += param.Step;
                    return true;
                }
                else
                {
                    param.Value = param.Start;
                    return incrementParam(ind - 1);
                }
            }
            else
            {
                return false;
            }
        }

public override double NumberOfRuns
        {
            get
            {
                double res = 1d;
                foreach (StrategyParameter param in WealthScript.Parameters) res *= param.NumberOfRuns;
                return res;
            }
        }
        public override string Description { get { return "Test Optimizer"; } }
        public override string FriendlyName { get { return "Test"; } }
        #region ICustomSettings implementation
        //Return the settings UI
        public System.Windows.Forms.UserControl GetSettingsUI()
        {
...
            {
                _settingsUI = new Abacus_User_Interface.UserControls();
                _settingsUI.numberOfSteps = _numberOfSteps; // NOW GENERATING THE ERROR 'Abacus_User_Interface.UserControls.numberOfSteps' is inaccessible due to its protection level
                //private int _numberOfSteps = 5;
                //private bool _playSoundChecked = true;
...
            }
            return _settingsUI;
        }

...

#endregion
   
    }

}[/code]

LenMoz

#5

12/18/2016 4:25 AM

The line...

CODE:
Please log in to see this code.

seems to be trying to directly set a variable.

PSO is rather calling a Setter. So, an equivalent line from PSO

CODE:
Please log in to see this code.

is calling the following code...

CODE:
Please log in to see this code.

Look at me, teaching Windows Forms!

Panache

#6

12/19/2016 12:17 AM

Thanks again. The problem was even more basic than that. In my Options form, the variables are private by default. Changing them to public eliminated the problem.

abegy

#7

4/14/2020 2:05 PM

Hi Panache,

I have detected an unhandled exception.

To produce it, starts WLD and open a strategy and go to the optimizer. Select one optimizer and go to another one (without running it). Do it several time by selecting different optimizers. When you select ABACUS by this way, you have the unhandled exception :

System.ArgumentOutOfRangeException: InvalidArgument=Value '34' is not valid in 'SelectedIndex'.
Parameter name : SelectedIndex

This unhandled exception doesn't appear if you do the same action without selected ABACUS.
I hope you will be able to reproduce it.

I take this opportunity to tell you that I very like your optimizer ! It helps me a lot.

abegy

#8

4/20/2020 2:32 PM

Panache,

For your information, I see that the value (34) for the unhandled exception is the same value in the WealthLabConfig.txt file (line Abacus.Optimizer.Metric=34). I think you don't take into account the line Optimization.Scorecard=Basic Scorecard in the WealthLabConfig.txt which gives you the scorecard selected.