Only look for entries when Weekly indicator is rising

mgreco19

#1

8/24/2017 3:00 PM

How would I code to only look for daily entries while the weekly derivative oscillator histogram or MACD Histogram is rising in value? ex. The weekly derivative oscillator for AAPL was rising from 12/9/16 to 3/10/17 and I would only look to enter trades during this time let's say if price dropped below SMA 20 to buy at market.

Eugene

#2

8/24/2017 3:49 PM

There are lots of examples on the forum and in Wealth-Lab itself. Check them out:

1. WealthScript Programming Guide > Multi-Time Frame Analysis > Daily/Weekly
2. Built-in "Elder Triple Screen" system
3. Some downloadable Strategies based on multiple time frames i.e. Weekly:

RSI Trifecta
ActiveTrader 2009-04 | Crossover system filtered by Impulse system (weekly)

mgreco19

#3

8/25/2017 4:00 AM

Thanks, Eugene. I took a look at the scripts and found the Elder Triple Screen helpful but I'm still doing something wrong here because trades are still triggering in the down trend. Can you let me know what I'm doing wrong here?

CODE:
Please log in to see this code.

Size:

Color:

Thanks, Eugene. I took a look at the scripts and found the Elder Triple Screen helpful but I'm still doing something wrong here because trades are still triggering in the down trend. Can you let me know what I'm doing wrong here?

[code]		using System;
		using System.Collections.Generic;
		using System.Text;
		using System.Drawing;
		using WealthLab;
		using WealthLab.Indicators;
		using Community.Indicators;

namespace WealthLab.Strategies
{
	public class MyStrategy : WealthScript
	{
		
		protected override void Execute()				
		{
			bool upTrend = false;
			Color colorUp = Color.FromArgb(220,255,220);
			Color colorDown = Color.FromArgb(255,220,220);
			SetScaleWeekly();
			DataSeries CompBar = Close * 0;
			CompBar.Description = "Compressed Bar Number";
			for (int bar = 0; bar < Bars.Count; bar++)	// load the bar numbers
				CompBar[bar] = bar;
			DataSeries DOweekly = DerivativeOscillator.Series(Close,14,5,3,9);
			RestoreScale();			
			DataSeries LowerBB = BBandLower.Series( Close, 20, 2 );
			DataSeries UpperBB = BBandUpper.Series( Close, 20, 2 );
			DataSeries DOdaily = DerivativeOscillator.Series(Close,14,5,3,9);
			DataSeries VolumeMA = SMA.Series(Volume,21);
			DataSeries ma20 = SMA.Series(Close,20);
			DOweekly = Synchronize( DOweekly );
			DataSeries DO_Weekly = Synchronize(DOweekly);
			DataSeries GetWeeklyBar = Synchronize(CompBar);
			
			ChartPane dodaily = CreatePane( 40,true,true );
			PlotSeries( dodaily, DOdaily, Color.Violet, LineStyle.Histogram, 2 );
			ChartPane doweekly = CreatePane( 40,true,true );
			PlotSeries( doweekly, DOweekly, Color.Black, LineStyle.Histogram, 2 );

for(int bar = GetTradingLoopStartBar(20); bar < Bars.Count; bar++)
	
			{
				//See if there was a change in long-term trend
				if (DOweekly[bar] > DOweekly[bar - 1])
					upTrend = true;
				else if (DOweekly[bar] < DOweekly[bar - 1])
					upTrend = false;
				
				//Set background color based on long term trend
				if (upTrend)
					SetBackgroundColor(bar, colorUp);
				else
					SetBackgroundColor(bar, colorDown);

if (IsLastPositionActive)
					{
					Position p = LastPosition;
					if ((DOdaily[bar] < DOdaily[bar-1]) & (DOdaily[bar-1] < DOdaily[bar-2]))
						SellAtMarket(bar+1,p,"DOdaily");
					else if (upTrend = false)
						SellAtMarket (bar+1,p,"DOtrendend");
				}
					else
					{
					
					
					bool Rule0 = upTrend = true;
					bool Rule1 = Close[bar] > 5;
					bool Rule2 = SMA.Series( Volume,21 )[bar] > 250000;
					bool Rule3 = DOweekly[bar] > DOweekly[bar-1];
					bool Rule4 = DOweekly[bar] < 0;
					bool Rule5 = Close[bar] < ma20[bar];
					
					
					if( Rule0 && Rule1 && Rule2 && Rule4 && Rule5)
					{
						BuyAtMarket( bar+1, "BuyMarket");
					}
					}
					}

}
		}
	}[/code]

Eugene

#4

8/25/2017 6:15 AM

You're making good progress. Your intention was to compare for equality but a couple of syntax errors has turned it into an assignment i.e. an everlasting uptrend or downtrend:

CODE:
Please log in to see this code.

mgreco19

#5

10/9/2017 10:42 PM

I'm trying to do a similar trend rule where when a weekly moving average is moving up a consecutive number of days it starts an uptrend and it ends after a consecutive number of days down. I've pretty much just replaced the DOweekly with MAweekly from the above code but it looks like it's just getting stuck in a down trend.

CODE:
Please log in to see this code.

Eugene

#6

10/10/2017 5:18 AM

Should I guess how the MAweekly is defined and positioned in the code? ;)

mgreco19

#7

10/10/2017 11:02 AM

ha you could try but probably better for me to just do that in the first place :)

CODE:
Please log in to see this code.

Size:

Color:

ha you could try but probably better for me to just do that in the first place :)

[code]using System;
using System.Collections.Generic;
using System.Text;
using System.Drawing;
using WealthLab;
using WealthLab.Indicators;
using Community.Indicators;

namespace WealthLab.Strategies
{
	public class MyStrategy : WealthScript
	{
		
		protected override void Execute()
		{
			bool upTrend = false;
			Color colorUp = Color.FromArgb(220,255,220);
			Color colorDown = Color.FromArgb(255,220,220);
			SetScaleWeekly();
			DataSeries CompBar = Close * 0;
			CompBar.Description = "Compressed Bar Number";
			for (int bar = 0; bar < Bars.Count; bar++)	// load the bar numbers
				CompBar[bar] = bar;
			DataSeries MAweekly = SMA.Series(Close,20);
			RestoreScale();
			DataSeries DOdaily = DerivativeOscillator.Series(Close,14,5,3,9);

MAweekly = Synchronize( MAweekly );
			DataSeries MA_Weekly = Synchronize(MAweekly);
			DataSeries GetWeeklyBar = Synchronize(CompBar);
			
			for(int bar = GetTradingLoopStartBar(2); bar < Bars.Count; bar++)
			{
				//See if there was a change in long-term trend
				if (CumUp.Value(bar, MAweekly, 1) >=3)
					upTrend = true;
				else if (CumDown.Value(bar, MAweekly, 1) >=3);
					upTrend = false;
				
				//Set background color based on long term trend
				if (upTrend)
					SetBackgroundColor(bar, colorUp);
				else
					SetBackgroundColor(bar, colorDown);

if (IsLastPositionActive)
				{
					Position p = LastPosition;
					if ((DOdaily[bar] < 0))
						SellAtMarket(bar+1,p,"DOstop");
					else if (upTrend == false)
						SellAtMarket (bar+1,p,"DOtrendend");
				}
				else
				{
               
               
					bool Rule0 = upTrend == true;
					bool Rule1 = Close[bar] > 5;
					bool Rule2 = SMA.Series( Volume,21 )[bar] > 250000;
					bool Rule3 = DOdaily[bar] > 0;
					bool Rule4 = DOdaily[bar-1] < 0;
										
					if( Rule0 && Rule1 && Rule2 && Rule3 && Rule4)
					{
						BuyAtMarket( bar+1, "BuyMarket");
					}
				}
			}

}
	}
}[/code]

Eugene

#8

10/10/2017 11:53 AM

The code is OK on the surface except a popular error. Actually, the culprit was seen straight in your reply #5. Take a careful look at the first line which contains the subtle error:

CODE:
Please log in to see this code.

Now, when you find out what makes it different from the correct syntax of the line above it (see below), you'll know what to fix.

CODE:
Please log in to see this code.

mgreco19

#9

10/10/2017 12:38 PM

All I see is the ; which I've removed prior to posting and it doesn't work correctly. The ; actually should have been removed before posting but I'm obviously missing something here.

Eugene

#10

10/10/2017 12:54 PM

The ";" is what makes the difference. It is not removed prior to posting. See your own post #7 above.

Don't forget to recompile after making changes.

mgreco19

#11

10/10/2017 1:03 PM

I've tried both with and without the ";". yes it wasn't removed before posting in the forum, what I meant was it should have as I've tested with both.

Whatever the case, when I copy the code from #7, remove the ";", recompile and run, the chart it's entirely red signaling a down trend. I'm running over a 4 year period.

Eugene

#12

10/10/2017 1:23 PM

I see now, it doesn't play a role. The error is in the logic: the MAweekly cannot take a 3 value. If you plot it on the chart you should see that...

CODE:
Please log in to see this code.

...it may change on Fridays only (typical behavior of compressed series). Since there cannot be 3 increases in a row, as a quick & dirty solution you may want to change the "1" to "5" (the number of daily bars in a week):

CODE:
Please log in to see this code.

mgreco19

#13

10/10/2017 5:08 PM

Thanks! That get's it closer but it's still off some. For example, if we look at TQQQ, I would think that it would switch to an uptrend on 6/10/16 but instead it changes midway through 5/27. Also, why would it switch midway through and not at the end when you see the increase?

Eugene

#14

10/10/2017 6:11 PM

That's right, my quick take at it was imprecise. Here's how you probably envisioned it - with CumUp/CumDown on Weekly scale:

CODE:
Please log in to see this code.

Size:

Color:

That's right, my quick take at it was imprecise. Here's how you probably envisioned it - with CumUp/CumDown on Weekly scale:

[code]using System;
using System.Collections.Generic;
using System.Text;
using System.Drawing;
using WealthLab;
using WealthLab.Indicators;
using Community.Indicators;

namespace WealthLab.Strategies
{
	public class MyStrategy : WealthScript
	{
      
		protected override void Execute()
		{
			bool upTrend = false;
			Color colorUp = Color.FromArgb(220,255,220);
			Color colorDown = Color.FromArgb(255,220,220);
			SetScaleWeekly();
			DataSeries MAweekly = SMA.Series(Close,20);
			DataSeries cu = CumUp.Series(MAweekly, 1);
			DataSeries cd = CumDown.Series(MAweekly, 1);
			RestoreScale();
			DataSeries DOdaily = DerivativeOscillator.Series(Close,14,5,3,9);

cu = Synchronize( cu );
			cd = Synchronize( cd );
			MAweekly = Synchronize( MAweekly );
			PlotSeries(PricePane,MAweekly,Color.Blue,WealthLab.LineStyle.Solid,1);
			
			for(int bar = GetTradingLoopStartBar(2); bar < Bars.Count; bar++)
			{
				//See if there was a change in long-term trend
				if (cu[bar] >=3)
					upTrend = true;
				else if (cd[bar] >=3)
					upTrend = false;
            
				//Set background color based on long term trend
				if (upTrend)
					SetBackgroundColor(bar, colorUp);
				else
					SetBackgroundColor(bar, colorDown);

if (IsLastPositionActive)
				{
					Position p = LastPosition;
					if ((DOdaily[bar] < 0))
						SellAtMarket(bar+1,p,"DOstop");
					else if (upTrend == false)
						SellAtMarket (bar+1,p,"DOtrendend");
				}
				else
				{
               
               
					bool Rule0 = upTrend == true;
					bool Rule1 = Close[bar] > 5;
					bool Rule2 = SMA.Series( Volume,21 )[bar] > 250000;
					bool Rule3 = DOdaily[bar] > 0;
					bool Rule4 = DOdaily[bar-1] < 0;
                              
					if( Rule0 && Rule1 && Rule2 && Rule3 && Rule4)
					{
						BuyAtMarket( bar+1, "BuyMarket");
					}
				}
			}

}
	}
}[/code]